Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkgdown example #28

Closed
coatless opened this issue Dec 20, 2019 · 2 comments
Closed

Pkgdown example #28

coatless opened this issue Dec 20, 2019 · 2 comments

Comments

@coatless
Copy link
Contributor

Based on discussion in maxheld83/ghpages#1, maxheld83/ghpages#18, and reading GitHub's Authenticating with the GITHUB_TOKEN help doc, I think the Pkgdown github action example needs to be switched from:

- name: Deploy package
run: |
Rscript -e "pkgdown:::deploy_local(new_process = FALSE, remote_url = 'https://x-access-token:${{secrets.GITHUB_TOKEN}}@github.com/${{github.repository}}.git')"

To:

run: |
   pkgdown:::deploy_local(new_process = FALSE, remote_url = 'https://x-access-token:${{secrets.DEPLOY_PAT}}@github.com/${{github.repository}}.git')
   shell: Rscript {0}

Emphasize that DEPLOY_PAT needs to be generated once and manually set for each repo under Secrets.

@jimhester
Copy link
Member

With changes to pkgdown, this is now fixed without the need for a DEPLOY_PAT

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants