Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-tinytex action documentation has wrong version info #505

Closed
jtbayly opened this issue Feb 17, 2022 · 7 comments
Closed

setup-tinytex action documentation has wrong version info #505

jtbayly opened this issue Feb 17, 2022 · 7 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@jtbayly
Copy link

jtbayly commented Feb 17, 2022

At least on MacOS, the following from the documentation doesn't work right:

      - uses: r-lib/actions/setup-tinytex@v2
        env:
          # always install the bundled version from Nov. 2021
          TINYTEX_VERSION: 2021-11

The correct version uses a period instead of a dash, like so:

          TINYTEX_VERSION: 2021.11

Unfortunately, this took me a long time to track down, in part because the action doesn't realize that it failed. Here's the job output for my step installing TinyTeX:

Run r-lib/actions/setup-tinytex@v[2](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:2)
2
  env:
[3](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:3)
    R_LIBS_USER: /Users/runner/work/_temp/Library
[4](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:4)
    TZ: UTC
[5](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:5)
    _R_CHECK_SYSTEM_CLOCK_: FALSE
[6](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:6)
    NOT_CRAN: true
[7](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:7)
    TINYTEX_VERSION: 2021-11
[8](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:8)
sh /Users/runner/work/_temp/install-unx.sh
[9](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:9)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[10](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:10)
                                 Dload  Upload   Total   Spent    Left  Speed
[11](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:11)

[12](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:12)
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
[13](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:13)
100     9  100     9    0     0     60      0 --:--:-- --:--:-- --:--:--    62
[14](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:14)
tar: Error opening archive: Unrecognized archive format
[15](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:15)
/Users/runner/work/_temp/install-unx.sh: line 59: cd: /Users/runner/Library/TinyTeX/bin/*/: No such file or directory
[16](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:16)
/Users/runner/work/_temp/install-unx.sh: line 61: ./tlmgr: No such file or directory
[17](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:17)
/Users/runner/work/_temp/install-unx.sh: line 63: ./tlmgr: No such file or directory
[18](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:18)
(node:1597) UnhandledPromiseRejectionWarning: Failed to install TinyTeX: Error: The process 'sh' failed with exit code 127
[19](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:19)
(node:1597) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
[20](https://github.com/warhornmedia/bannerman-sacraments/runs/5233678630?check_suite_focus=true#step:5:20)
(node:1597) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The workflow should have failed right there, but instead it failed several steps later when it attempted to use TinyTeX.

@jtbayly jtbayly added the bug an unexpected problem or unintended behavior label Feb 17, 2022
@gaborcsardi
Copy link
Member

gaborcsardi commented Feb 17, 2022

Thanks! Do you want to submit a PR against the v2-branch branch?

@jtbayly
Copy link
Author

jtbayly commented Feb 17, 2022

I was going to, but I wasn't sure if the second part of my issue should also be addressed?

@jtbayly
Copy link
Author

jtbayly commented Feb 17, 2022

(Just to be clear, I could easily fix the first part, but the second part is way beyond me.)

@gaborcsardi
Copy link
Member

Yes, fixing the docs would be nice, thanks! (But no pressure.)

@gaborcsardi
Copy link
Member

Actually, I am fixing the second issue, so never mind. :)

@gaborcsardi
Copy link
Member

OK, the error messages are still not great because the install script does not stop at the failed download, but at least the action fails now: https://github.com/r-lib/actions/runs/5246523414?check_suite_focus=true

This will be in v2 later today.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants