Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to find version master #639

Closed
bschilder opened this issue Oct 19, 2022 · 9 comments
Closed

unable to find version master #639

bschilder opened this issue Oct 19, 2022 · 9 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@bschilder
Copy link

It looks like the master branch was removed. Can this please be added back, as it breaks all GHA workflows that specify @master.

For example:

https://github.com/neurogenomics/EpiCompare/actions/runs/3284944299/jobs/5411492406

Screenshot 2022-10-19 at 22 03 10

Thanks,
Brian

@bschilder bschilder added the bug an unexpected problem or unintended behavior label Oct 19, 2022
@beansrowning
Copy link

beansrowning commented Oct 19, 2022

use @v2

@bschilder
Copy link
Author

Version control is fine when you make new releases, but it's best practice to keep a master/main branch as the default. I have 30+ R packages that use this GH Action that I would need to change the workflow files for. I anticipate many other users will encounter this issue.

Thanks!

@beansrowning
Copy link

Not the GHA author, just providing a solution since mine broke today also. I don't think they plan to bring back a "master", unfortunately.

@gaborcsardi
Copy link
Member

Note that @master was never meant for public use. It is actually still available under the name @old, but it hasn't been updated for about a year now, and soon most actions in it will stop working, because GHA will drop support for node.js 12, which @old actions use.

It is much better to use the @v2 sliding tag, the actions there work much better than the ones in @old.

@bschilder
Copy link
Author

bschilder commented Oct 24, 2022

Thanks for the clarification @gaborcsardi

Giving a heads up to @lcolladotor as I think this affects the biocthis workflows as well.
https://github.com/lcolladotor/biocthis

@vjcitn
Copy link

vjcitn commented Oct 24, 2022

New to the field ... was there any kind of warning/deprecation process for setup-r@master change? If so I'd like to know what to watch out for. If not, is this possible?

@gaborcsardi
Copy link
Member

@vjcitn See the README: https://github.com/r-lib/actions#github-actions-for-the-r-language You can subscribe to new releases if you want to get notified about changes.

@lcolladotor
Copy link
Contributor

Thanks for the ping and messages! I just updated biocthis thanks to @zeehio at lcolladotor/biocthis#37.

Best,
Leo

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
@gaborcsardi gaborcsardi unpinned this issue May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

5 participants