Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Introduce R-CMD-check-offline workflow? #658

Closed
IndrajeetPatil opened this issue Nov 8, 2022 · 3 comments
Closed

FR: Introduce R-CMD-check-offline workflow? #658

IndrajeetPatil opened this issue Nov 8, 2022 · 3 comments
Labels
feature a feature request or enhancement

Comments

@IndrajeetPatil
Copy link
Contributor

The R-CMD-check-hard makes sure that all examples and tests that require suggested dependencies use them conditionally and with skip_if_not_installed(....), respectively.

In other words, you can use this workflow to find tests that should have skip_if_not_installed(....).


Similar to this workflow, I was wondering if it might be a good idea to introduce R-CMD-check-offline workflow, which will make sure that all examples and tests that require internet access are being run conditional on internet access availability.

In other words, you can use this workflow to find tests that should have skip_if_offline().

If you agree, I'd also be happy to make a PR, but I am having a hard time figuring out how to mimic no internet access during R CMD check. Couldn't find anything relevant in {curl}.

@IndrajeetPatil IndrajeetPatil changed the title FR: Introduce R-CMD-check-offline? FR: Introduce R-CMD-check-offline workflow? Nov 8, 2022
@gaborcsardi
Copy link
Member

I can see that this could be useful. OTOH we are starting to accumulate example workflows that are never tested, so their qualities might vary in the future.

I am not sure about the right solution for this, maybe we could create a separate repo, or have a separate directory, to make it clear which workflows are part of the "core".

As for the implementation, you could probably create a Docker container with all dependencies installed, and then run R CMD check, or the examples + vignettes + tests with the network disconnected from the container.

@gaborcsardi
Copy link
Member

While this is a good idea, it didn't seem to get much traction, so I am going to close it now. Feel free to open another issue if you want to work on this.

Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants