Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore rtools40 path #504

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

nealrichardson
Copy link
Contributor

On apache/arrow#12436 I was trying to update our workflows to use v2 but ran into a problem where pacman could not be found (we use the pacman bundled with rtools as part of building C++ dependencies for the R package).

Doing some digging, it looks like 18ab426 inadvertently removed the line that adds rtools to the path for rtools40.

To confirm, I set up a simple workflow here that looks for pacman. It confirms it is working on master but not v2, and that this PR fixes the issue.

@codecov-commenter
Copy link

Codecov Report

Merging #504 (a66acd8) into v2-branch (77eeb6b) will not change coverage.
The diff coverage is n/a.

❗ Current head a66acd8 differs from pull request most recent head 4bb164f. Consider uploading reports for the commit 4bb164f to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           v2-branch      #504   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819c6b8...4bb164f. Read the comment docs.

@gaborcsardi
Copy link
Member

Thanks much!

@gaborcsardi gaborcsardi merged commit 761250d into r-lib:v2-branch Feb 16, 2022
@gaborcsardi
Copy link
Member

This is in v2 now.

@nealrichardson nealrichardson deleted the rtools-path branch February 16, 2022 15:17
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants