Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility issues in resulting SVGs (unusable in firefox if minimum font size and font size are set) #42

Closed
masukomi opened this issue Aug 4, 2022 · 3 comments · Fixed by #43

Comments

@masukomi
Copy link

masukomi commented Aug 4, 2022

screenshot of readme from firefox with large fonts:

CleanShot 2022-08-04 at 10 19 42@2x

This is related to a known, and thoroughly ignored, firefox issue.

I've seen this fixed before by running the following against the resulting svg.

sed -i '' 's/<text/<text font-size="1.67"/g' doc/screencast.svg

You can replicate it by setting your font size to 20 and your minimum font size to 20.

note: in chrome with large fonts it's visible BUT it's also much smaller than the surrounding text so, may be particularly difficult for people who have trouble with small fonts.

CleanShot 2022-08-04 at 10 24 49@2x

gaborcsardi added a commit that referenced this issue Aug 5, 2022
@gaborcsardi
Copy link
Member

gaborcsardi commented Aug 5, 2022

Hopefully this is fixed in this branch: https://github.com/r-lib/asciicast/tree/fix/firefox-font-size
(You might need to clear the cache in Firefox.)

@gaborcsardi gaborcsardi changed the title accessibility issues in resulting SVGs (unusable in firefox) accessibility issues in resulting SVGs (unusable in firefox if minimum font size and font size are set) Aug 5, 2022
@gaborcsardi
Copy link
Member

With #43 merged, the dev pkgdown site should look good for you already: https://r-lib.github.io/asciicast/dev/

@masukomi
Copy link
Author

lovely. thank you @gaborcsardi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants