Wrong regex in valid_package_name_regexp

[KevCaz]

Here are two examples where I think valid_package_name() is misbehaving.

R> valid_package_name("!r2!")
Name valid: ✔

R> valid_package_name("!r2 _ r2!")
Name valid: ✔

According to https://cran.r-project.org/doc/manuals/r-release/R-exts.html#The-DESCRIPTION-file

This should contain only (ASCII) letters, numbers and dot, have at least two characters and start with a letter and not end in a dot

so my understanding is that ^ and $ are missing in valid_package_name_regexp (and so in standard_regexps()$valid_package_name)

valid_package_name2 <- function(name) {

  # This is the algorithm used in R CMD check at
  # https://github.com/wch/r-source/blob/a3a73a730962fa214b4af0ded55b497fb5688b8b/src/library/tools/R/QC.R#L3214
  valid <- TRUE

  # check for a package called 'R'
  res <- if (tolower(name) == "r") {
    FALSE
  } else {
    grepl(glue::glue("^{valid_package_name_regexp}$"), name)
  }
  structure(res, class = "available_valid_name")
}

now

R> valid_package_name2("!r2!")
Name valid: ✖

R> valid_package_name2("!r2 _ r2!")
Name valid: ✖

R> valid_package_name2("r2")
Name valid: ✔

If this is right and useful, I can create a PR.

[llrs]

Shouldn't this be closed by #64 ?

[KevCaz]

Yup. Thanks!