-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: option to switch off memory profiling #62
Comments
Thank you for suggesting this @fabian-s ! |
I probably won't be working on bench for a bit, but happy to review PRs if anyone wants to implement something in the meantime. |
ok, fair enough -- if I were to implement this I would
does that seem reasonable? |
PS: Note that to enable benchmarking for parallelized code, this comment seems to say you'd have to eventually use (the next version of) |
Measuring memory is not only a problem for a parallelized code, it is not reliable because it tracks only R C |
I added a warning in the documentation to clarify what this tracks and avoid misinterpreting the results, I will add an option to control the profiling directly in the future, so this issue will remain open to track that. |
Fixed by fce1e23 |
since memory profiling does not seem to work reliably for parallelized code (see below and HenrikBengtsson/profmem#14),
bench
should allow switching off memory profiling or wrapparse_allocations
intryCatch
so that timings are returned reliably even if memory does not work.a
no_memprof
option would also be nice for #60.reprex
:Created on 2019-10-06 by the reprex package (v0.3.0)
Session info
The text was updated successfully, but these errors were encountered: