Remove continuous benchmarking infrastructure #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning on removing the continuous benchmarking infrastructure from bench. This decision is being made for a few reasons:
refs/notes/benchmarks
and that shows them to you.It has been in the dev version for awhile, so I am going to park the current implementation in a branch. tibble can use this if it needs some temporary support. That branch is
frozen/continuous-benchmarking
https://github.com/r-lib/bench/tree/frozen/continuous-benchmarking.There is also some additional work in https://github.com/r-lib/bench/tree/CB where development was pushed forward a little further, but was never merged in.
It would be nice to figure out a way to pick this back up in the future, in particular for rlang, vctrs, and dplyr's vector functions like
case_when()
andfirst()
. Having benchmarks in place for those lower level tools could have likely avoided some of the patches needed in dplyr 1.1.0 related to performance issues.