Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run init function of client lib #250

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Run init function of client lib #250

merged 1 commit into from
Apr 5, 2023

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Apr 5, 2023

The client library needs to be named client.so or client.dll because R finds the R_init_client function from the file name.

This PR moves the metadata encoded in the name to the directory structure, e.g. /tmp/RtmpUipw23/callr-client--7fc6a31.so becomes /tmp/RtmpMeE1ZE/callr//7fc6a31/client.so.

@lionel- lionel- requested a review from gaborcsardi April 5, 2023 10:34
@gaborcsardi gaborcsardi merged commit e3e0acf into main Apr 5, 2023
@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi deleted the fix-client-so-name branch April 5, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants