Make sure that each verbatim line is styled separately #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborcsardi
reviewed
Mar 19, 2020
… issue with only the first line of verbatim displaying properly in themed containers; added test for this
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 80.16% 80.16%
=======================================
Files 30 30
Lines 1467 1467
=======================================
Hits 1176 1176
Misses 291 291
Continue to review full report at Codecov.
|
|
Ah yes, sorry about that, I hope to have fixed it now. Another note: I am not sure whether it will correctly work on all platforms and across all inputs due to how new lines are handled. A more robust way would be to use something like stri_split_lines() but I am not sure that you want to add an additional dependency... |
|
@gaborcsardi Is there something else I need to fix? Just wanted to ask in case you are waiting for me. |
|
No, it is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #146