Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that each verbatim line is styled separately #147

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

tzakharko
Copy link
Contributor

Fix for #146

Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Can you please fix the spaces to match the code style? Then I'll be happy to merge. Thanks!

R/cliapp.R Outdated Show resolved Hide resolved
tests/testthat/test-verbatim.R Outdated Show resolved Hide resolved
tests/testthat/test-verbatim.R Outdated Show resolved Hide resolved
… issue with only the first line of verbatim displaying properly in themed containers; added test for this
@codecov-io
Copy link

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   80.16%   80.16%           
=======================================
  Files          30       30           
  Lines        1467     1467           
=======================================
  Hits         1176     1176           
  Misses        291      291
Impacted Files Coverage Δ
R/cliapp.R 83.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b708e...d77eb20. Read the comment docs.

@tzakharko
Copy link
Contributor Author

Ah yes, sorry about that, I hope to have fixed it now.

Another note: I am not sure whether it will correctly work on all platforms and across all inputs due to how new lines are handled. A more robust way would be to use something like stri_split_lines() but I am not sure that you want to add an additional dependency...

@tzakharko
Copy link
Contributor Author

@gaborcsardi Is there something else I need to fix? Just wanted to ask in case you are waiting for me.

@gaborcsardi
Copy link
Member

gaborcsardi commented Mar 25, 2020

No, it is good to go.

@gaborcsardi gaborcsardi merged commit b15c8b0 into r-lib:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants