Make sure that each verbatim line is styled separately#147
Make sure that each verbatim line is styled separately#147gaborcsardi merged 1 commit intor-lib:masterfrom
Conversation
gaborcsardi
left a comment
There was a problem hiding this comment.
Thanks, looks great! Can you please fix the spaces to match the code style? Then I'll be happy to merge. Thanks!
… issue with only the first line of verbatim displaying properly in themed containers; added test for this
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 80.16% 80.16%
=======================================
Files 30 30
Lines 1467 1467
=======================================
Hits 1176 1176
Misses 291 291
Continue to review full report at Codecov.
|
|
Ah yes, sorry about that, I hope to have fixed it now. Another note: I am not sure whether it will correctly work on all platforms and across all inputs due to how new lines are handled. A more robust way would be to use something like stri_split_lines() but I am not sure that you want to add an additional dependency... |
|
@gaborcsardi Is there something else I need to fix? Just wanted to ask in case you are waiting for me. |
|
No, it is good to go. |
Fix for #146