Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param sep2 #569

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Add param sep2 #569

merged 7 commits into from
Sep 13, 2023

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Jan 27, 2023

Fixes #568.

Some snapshot tests failed (i.e. produced different output). I think most of them currently also fail on the main branch, i.e. have nothing to do with this PR. But I noticed one particular test that might actually be caused by this PR:

I'm not familiar enough with cli to understand why that is, so I'll leave it to you. Hope that's fine. 馃檪 I've updated inline_collapse() which relies on ansi_collapse(). Should be fine now.

@salim-b
Copy link
Contributor Author

salim-b commented Mar 29, 2023

@gaborcsardi Friendly reminder to have a look at this. 馃檪

@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi merged commit 641fe8c into r-lib:main Sep 13, 2023
12 checks passed
@salim-b salim-b deleted the sep2 branch September 13, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansi_collapse() with length-2 input
2 participants