Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage not counted on brace lines #387

Closed
billdenney opened this issue Aug 4, 2019 · 1 comment
Closed

Coverage not counted on brace lines #387

billdenney opened this issue Aug 4, 2019 · 1 comment
Labels
feature a feature request or enhancement

Comments

@billdenney
Copy link

I think that this is subtly different than #363, but it is related. (Sorry if it is a duplicate.)

When I have a function factory similar to #363 (see https://codecov.io/gh/billdenney/pknca/commit/cef59c91c5ac4ecc39ed5a73b4f784844d0bc1fb#D7-255, specifically lines 255, 258, and 260), the interstitial parts of if blocks are not counted: the closing braces and the else.

I see from #363 that 251 and 261 are not run during testing, so they need a #nocov, and I know that I could add #nocov to lines 255, 258, and 260, but if it's reasonable to have covr detect that those lines are implicitly tested, that seems preferable.

@jimhester jimhester added the feature a feature request or enhancement label Aug 5, 2019
@billdenney
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants