Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small files pane in covr::report() #494

Closed
MeterDS2021 opened this issue Dec 3, 2021 · 1 comment
Closed

Small files pane in covr::report() #494

MeterDS2021 opened this issue Dec 3, 2021 · 1 comment

Comments

@MeterDS2021
Copy link

MeterDS2021 commented Dec 3, 2021

As of late, the files pane in covr::report() has a very low height although the actual viewer window in RStudio is much larger.

image

When clicking on a particular file (ie opening a new tab), the pane extends to the full height. Also, the problem persists when setting options(viewer=NULL), so I wouldn't expect this to be an RStudio issue.

> sessionInfo()
R version 4.1.2 (2021-11-01)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 20.04.3 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.9.0
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.9.0

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C               LC_TIME=de_DE.UTF-8       
 [4] LC_COLLATE=en_US.UTF-8     LC_MONETARY=de_DE.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=de_DE.UTF-8       LC_NAME=C                  LC_ADDRESS=C              
[10] LC_TELEPHONE=C             LC_MEASUREMENT=de_DE.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] prompt_1.0.1      digest_0.6.29     withr_2.4.3       R6_2.5.1          jsonlite_1.7.2   
 [6] covr_3.5.1.9003   magrittr_2.0.1    rlang_0.4.12      cli_3.1.0         lazyeval_0.2.2   
[11] jquerylib_0.1.4   rex_1.2.1         bslib_0.3.1       DT_0.20           tools_4.1.2      
[16] htmlwidgets_1.5.4 crosstalk_1.2.0   yaml_2.2.1        fastmap_1.1.0     compiler_4.1.2   
[21] htmltools_0.5.2   sass_0.4.0
jimhester added a commit that referenced this issue Dec 3, 2021
Something seems wrong with DT's autodetection, it is making the table
much too small.

Unfortunately I don't have time to track down the root cause, and simply
disabling the auto fill improves the situation.

Fixes #494
@jimhester
Copy link
Member

There seems to be something wrong with DTs automatic detection of fill height, in particular the fillContainer argument of datatable::DT(). Maybe an interaction with newer versions of bootstrap or something along those lines.

A workaround is to stop using this parameter, which is what I did here. It might be worth opening an issue in the DT repository to try to address the root cause though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants