Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobertura coverage-04.dtd validation? #524

Closed
mmyrte opened this issue Mar 1, 2023 · 2 comments
Closed

Cobertura coverage-04.dtd validation? #524

mmyrte opened this issue Mar 1, 2023 · 2 comments

Comments

@mmyrte
Copy link
Contributor

mmyrte commented Mar 1, 2023

While trying to use the coverage report generated by to_cobertura in VS Code for nicely color-coded coverage gutters, I have found the following issues with the XML currently being generated:

  • The <method> nodes are currently generated without a complexity attribute, which may or may not be required. Should I add a complexity="0" attribute just for safety's sake? This would entail being explicit about the DTD we claim to adhere to.
  • The parser which the above mentioned Coverage Gutters project uses expects a filled <sources> node as child of the <coverage> node. Neither of the two DTDs actually expects at least one child, but I think adding the current working directory would not hurt.

@jimhester has touched the relevant R/cobertura.R before; good if I base a PR off of this issue?

@jimhester
Copy link
Member

Sure, that would be great.

@jimhester
Copy link
Member

Fixed by #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants