Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-license as MIT #498

Merged
merged 3 commits into from Feb 2, 2022
Merged

Re-license as MIT #498

merged 3 commits into from Feb 2, 2022

Conversation

batpigandme
Copy link
Contributor

hadley
hadley reviewed Jan 19, 2022
View reviewed changes
.Rbuildignore Outdated Show resolved Hide resolved
@hadley
Copy link
Member

hadley commented Jan 20, 2022

Hmmm, not sure why we're getting these failures.

@batpigandme
Copy link
Contributor Author

Just tried moving it up even higher… It's not terribly high up in .Rbuildignore for other packages (e.g. in usethis https://github.com/r-lib/usethis/blob/57b109ab1e376d8fbf560e7e6adc19e0a04c5edd/.Rbuildignore#L12), so I'm not sure why that's causing those failures.

@hadley
Copy link
Member

hadley commented Jan 21, 2022

Sorry, I should've been more clear; it seems unlikely that it's your change causing these failures.

@jimhester jimhester merged commit 2eb61fc into main Feb 2, 2022
@jimhester jimhester deleted the relicense branch February 2, 2022 20:28
@robertzk robertzk mentioned this pull request Feb 2, 2022
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-licensing covr as MIT
3 participants
@batpigandme @hadley @jimhester