Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: cpp_register() could allow non-.cpp extensions #292

Closed
MichaelChirico opened this issue Oct 11, 2022 · 1 comment · Fixed by #302
Closed

FR: cpp_register() could allow non-.cpp extensions #292

MichaelChirico opened this issue Oct 11, 2022 · 1 comment · Fixed by #302

Comments

@MichaelChirico
Copy link
Contributor

MichaelChirico commented Oct 11, 2022

Here, the resulting cpp11 file is hard-coded to have extension .cpp:

cpp_path <- file.path(path, "src", "cpp11.cpp")

But sometimes we may need to write .cc extensions (e.g. if the other source files are also written as .cc).

Is there any reason not to offer an extra argument (extension = ".cpp") to allow this customization?

Happy as ever to file a PR :)


FWIW, on GitHub I see ~160M files with extension .cpp, vs. ~50M for .cc

@MichaelChirico MichaelChirico changed the title FR: cpp_register() could allow FR: cpp_register() could allow non-.cpp extensions Oct 11, 2022
@romainfrancois
Copy link
Collaborator

No particular reason, I'll review a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants