Ext ptr tag #286
Closed
Ext ptr tag #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting/getting tag
Added test for setting/getting tag
Just trying to trigger checking actions
* Add missing letter 's' in 'logicals' * Update FAQ.Rmd
…estthat runs) (r-lib#289) * cpp_register(quiet=) set to TRUE on non-interactive session (incl testthat). * news * Apply suggestions from code review Co-authored-by: Davis Vaughan <davis@rstudio.com> * remove redundant cli_suppress() call * simplify with expect_snapshot() * remove cli_suppress() function as it's no longer needed. Co-authored-by: Davis Vaughan <davis@rstudio.com>
Allow setting/getting tag
Added test for setting/getting tag
Just trying to trigger checking actions
|
I've messed with the history in this PR. I'll extract the relevant changes in |
|
No worries. Actually, I ended up not using tags in my experiment. But it
would be helpful to wrap setting the protect object as I use that a lot.
…On Tue, Oct 11, 2022 at 11:55 AM Romain François ***@***.***> wrote:
I've messed with the history in this PR. I'll extract the relevant changes
in external-pojnter.hpp and test-external-pointer.cpp and do it again.
Sorry about the inconvenience.
—
Reply to this email directly, view it on GitHub
<#286 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQXSNZUYCKZIDTKVCEFBLWCWLXDANCNFSM6AAAAAAQPZAV7E>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Ok, let me close this then, and I'll pick up #287 in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to get/set tag on external pointer class.