Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering alphabetically dependencies. #66

Closed
llrs opened this issue Jul 27, 2018 · 2 comments
Closed

Ordering alphabetically dependencies. #66

llrs opened this issue Jul 27, 2018 · 2 comments

Comments

@llrs
Copy link
Contributor

llrs commented Jul 27, 2018

I was about to open this issue in usethis, but I saw it used desc to manage the DESCCRIPTION file. Let me know if I missed and should be on usethis.

When I use devtools::setup packages are added alphabetically:

Suggests: 
    knitr,
    rmarkdown,
    testthat

However when using usethis::use_package or anything that adds a package to the DESCRIPTION file like use_coverage, the packages are added at the end of the list:

Suggests: 
    knitr,
    rmarkdown,
    testthat,
    covr

Could it be added an option in desc_normalizeto sort the packages alphabetically? Perhaps in desc_normalize and in desc_set_dep as an argument?.

Suggests: 
    covr,
    knitr,
    rmarkdown,
    testthat
@gaborcsardi
Copy link
Member

I think it does not have be an option, desc_normalize should just do it. Do you want to submit a PR?

llrs added a commit to llrs/desc that referenced this issue Jul 28, 2018
@llrs
Copy link
Contributor Author

llrs commented Oct 9, 2018

It was merged on #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants