Skip to content

Commit

Permalink
Tweak cran comments template.
Browse files Browse the repository at this point in the history
Fixes #1038
  • Loading branch information
hadley committed Jan 21, 2016
1 parent ea87f93 commit aebc8ed
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 13 deletions.
2 changes: 2 additions & 0 deletions NEWS.md
@@ -1,5 +1,7 @@
# devtools 1.9.1.9000

* The template for `use_cran_comments()` has been improved (#1038).

* New strategy for detecting RTools on windows: devtools now only looks
for Rtools if you need to `load_all()` or `build()` a package with
compiled code. This should make it easier to work with devtools if
Expand Down
6 changes: 5 additions & 1 deletion R/infrastructure.R
Expand Up @@ -595,7 +595,11 @@ use_cran_comments <- function(pkg = ".") {
stop("cran-comments.md already exists", call. = FALSE)

message("Adding cran-comments.md template")
writeLines(render_template("cran-comments.md", list()), comments)
data <- list(
rversion = paste0(version$major, ".", version$minor)
)

writeLines(render_template("cran-comments.md", data), comments)
invisible()
}

Expand Down
26 changes: 14 additions & 12 deletions inst/templates/cran-comments.md
@@ -1,21 +1,23 @@
## Test environments
* local OS X install, R 3.1.2
* ubuntu 12.04 (on travis-ci), R 3.1.2
* local OS X install, R {{{ rversion }}}
* ubuntu 12.04 (on travis-ci), R {{{ rversion }}}
* win-builder (devel and release)

## R CMD check results
There were no ERRORs or WARNINGs.

There was 1 NOTE:
0 errors | 0 warnings | 1 note

* checking dependencies in R code ... NOTE
Namespace in Imports field not imported from: 'R6'
* This is a new release.

R6 is a build-time dependency.
## Reverse dependencies

## Downstream dependencies
I have also run R CMD check on downstream dependencies of httr
(https://github.com/wch/checkresults/blob/master/httr/r-release). All packages
that I could install passed except:
This is a new release, so there are no reverse dependencies.

* XYZ:...
---

* I have run R CMD check on the NUMBER downstream dependencies.
(Summary at ...).

* FAILURE SUMMARY

* All revdep maintainers were notified of the release on RELEASE DATE.

0 comments on commit aebc8ed

Please sign in to comment.