Merge pull request #434 from krlmlr/with_options

with_options works as expected

NEWS.md

@@ -1,5 +1,9 @@
 # devtools 1.4.1.99
 
+* The `with_options` works as expected, used to throw an error when trying to
+  set an option.
+  (Thanks to @krlmlr, #434)
+
 * In `build()`, use `--no-build-vignettes` (#391).
 
 * Bump R dependency to 3.0.2.

R/with.r

@@ -146,9 +146,13 @@ with_lib <- with_something(set_lib)
 
 # options --------------------------------------------------------------------
 
+set_options <- function(new_options) {
+  do.call(options, as.list(new_options))
+}
+
 #' @rdname with_something
 #' @export
-with_options <- with_something(options)
+with_options <- with_something(set_options)
 
 # par ------------------------------------------------------------------------
 

tests/testthat/test-with.r

@@ -31,3 +31,13 @@ test_that("with_envar respects suffix and prefix", {
   expect_equal(nested("suffix", "suffix"), c("1 2"))
   expect_equal(nested("suffix", "prefix"), c("2 1"))
 })
+
+test_that("with_options works", {
+  expect_that(getOption("scipen"), not(equals(999)))
+  expect_equal(with_options(c(scipen=999), getOption("scipen")), 999)
+  expect_that(getOption("scipen"), not(equals(999)))
+
+  expect_that(getOption("zyxxyzyx"), not(equals("qwrbbl")))
+  expect_equal(with_options(c(zyxxyzyx="qwrbbl"), getOption("zyxxyzyx")), "qwrbbl")
+  expect_that(getOption("zyxxyzyx"), not(equals("qwrbbl")))
+})