Skip to content

Commit

Permalink
Update check notes for release
Browse files Browse the repository at this point in the history
  • Loading branch information
hadley committed Apr 7, 2014
1 parent 9e70e8a commit b6fda81
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions rcmd-notes.md
@@ -1,10 +1,5 @@
The following notes were generated across my local OS X install, ubuntu running on travis-ci and win builder. Response to NOTEs across three platforms below.

* checking package dependencies ... NOTE

Note about rstudio package included in DESCRIPTION. Will be removed
once rstudioapi package is accepted.

* checking R code for possible problems ... NOTE
Found the following calls to attach():
File ‘devtools/R/package-env.r’:
Expand All @@ -20,3 +15,13 @@ The following notes were generated across my local OS X install, ubuntu running
file that is run in a fresh R session.

We also ran R CMD check on all reverse dependencies for r-release: https://github.com/wch/devtools-checkresults/blob/master/r-release/00check-summary.txt. The only failure is with NMF - the failing example seems unrelated to devtools, and it's hard to imagine why the package needs devtools at all.

Compared to the last submission, I have:

* Switched to using rstudioapi instead of rstudio

* Incremented the versions of R that Rtools 3.1 matches based on Brian's
comment (overriding the version specification from
http://cran.r-project.org/bin/windows/Rtools/)

I am aware that devtools does not work on Solaris.

0 comments on commit b6fda81

Please sign in to comment.