Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install* dependency lookup broken #1409

Closed
gaborcsardi opened this Issue Dec 1, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@gaborcsardi
Copy link
Member

gaborcsardi commented Dec 1, 2016

@hadley @jimhester this is kind of serious, because it often breaks install_github. I had two bug reports for two different packages because of this.

To reproduce, see the current https://github.com/r-pkgs/desc repo. desc imports rprojroot, which imports backports. If you don't have backports installed, then devtools does not try to install it, here is a quick comparison with remotes:

devtools::dev_package_deps()
Not on CRAN ----------------------------
 package    installed available remote
 assertthat 0.1.0.99  0.1       CRANremotes::dev_package_deps()
Needs update -----------------------------
 package    installed available
 backports  NA        1.0.4
Not on CRAN ----------------------------
 package    installed available
 assertthat 0.1.0.99  0.1

On this system:

❯ devtools::session_info()
Session info ------------------------------------------------------------------
 setting  value
 version  R version 3.3.2 (2016-10-31)
 system   x86_64, darwin13.4.0
 ui       X11
 language (EN)
 collate  en_US.UTF-8
 tz       Europe/London
 date     2016-12-01

Packages ----------------------------------------------------------------------
 package    * version     date       source
 clisymbols   1.0.0       2015-06-08 CRAN (R 3.2.0)
 crayon       1.3.2       2016-06-28 local
 devtools     1.12.0.9000 2016-11-23 Github (hadley/devtools@e6df6cf)
 digest       0.6.10      2016-08-02 CRAN (R 3.2.5)
 gitty        1.0.0       2016-11-17 local
 memoise      1.0.0       2016-01-29 CRAN (R 3.2.3)
 memuse       2.5         2015-07-02 CRAN (R 3.2.0)
 pkgbuild     0.0.0.9000  2016-11-27 Github (r-pkgs/pkgbuild@65eace0)
 pkgload      0.0.0.9000  2016-11-27 Github (r-pkgs/pkgload@def2b10)
 prettycode * 1.0.0       2016-11-15 local (gaborcsardi/prettycode@b0144d1)
 prompt       1.0.0       2016-11-23 local
 remotes      1.0.0       2016-09-08 Github (MangoTheCat/remotes@1141c19)
 tracer     * 1.0.0       2016-11-30 local (gaborcsardi/tracer@NA)
 whisker      0.3-2       2013-04-28 CRAN (R 3.3.0)
 withr        1.0.2       2016-06-20 CRAN (R 3.3.0)
@jimhester

This comment has been minimized.

Copy link
Member

jimhester commented Dec 1, 2016

Should be fixed by 1ce84b0.

Thank you for the good reprex, it was pretty easy to track down the issue looking at the devtools changes in respect to remotes.

@jimhester jimhester closed this Dec 1, 2016

@gaborcsardi

This comment has been minimized.

Copy link
Member Author

gaborcsardi commented Dec 1, 2016

Great, thanks for the quick fix!

@lock

This comment has been minimized.

Copy link

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.