install* dependency lookup broken

[gaborcsardi]

@hadley @jimhester this is kind of serious, because it often breaks install_github. I had two bug reports for two different packages because of this.

To reproduce, see the current https://github.com/r-pkgs/desc repo. desc imports rprojroot, which imports backports. If you don't have backports installed, then devtools does not try to install it, here is a quick comparison with remotes:

❯ devtools::dev_package_deps()
Not on CRAN ----------------------------
 package    installed available remote
 assertthat 0.1.0.99  0.1       CRAN

❯ remotes::dev_package_deps()
Needs update -----------------------------
 package    installed available
 backports  NA        1.0.4
Not on CRAN ----------------------------
 package    installed available
 assertthat 0.1.0.99  0.1

On this system:

❯ devtools::session_info()
Session info ------------------------------------------------------------------
 setting  value
 version  R version 3.3.2 (2016-10-31)
 system   x86_64, darwin13.4.0
 ui       X11
 language (EN)
 collate  en_US.UTF-8
 tz       Europe/London
 date     2016-12-01

Packages ----------------------------------------------------------------------
 package    * version     date       source
 clisymbols   1.0.0       2015-06-08 CRAN (R 3.2.0)
 crayon       1.3.2       2016-06-28 local
 devtools     1.12.0.9000 2016-11-23 Github (hadley/devtools@e6df6cf)
 digest       0.6.10      2016-08-02 CRAN (R 3.2.5)
 gitty        1.0.0       2016-11-17 local
 memoise      1.0.0       2016-01-29 CRAN (R 3.2.3)
 memuse       2.5         2015-07-02 CRAN (R 3.2.0)
 pkgbuild     0.0.0.9000  2016-11-27 Github (r-pkgs/pkgbuild@65eace0)
 pkgload      0.0.0.9000  2016-11-27 Github (r-pkgs/pkgload@def2b10)
 prettycode * 1.0.0       2016-11-15 local (gaborcsardi/prettycode@b0144d1)
 prompt       1.0.0       2016-11-23 local
 remotes      1.0.0       2016-09-08 Github (MangoTheCat/remotes@1141c19)
 tracer     * 1.0.0       2016-11-30 local (gaborcsardi/tracer@NA)
 whisker      0.3-2       2013-04-28 CRAN (R 3.3.0)
 withr        1.0.2       2016-06-20 CRAN (R 3.3.0)

[jimhester]

Should be fixed by 1ce84b0.

Thank you for the good reprex, it was pretty easy to track down the issue looking at the devtools changes in respect to remotes.

[gaborcsardi]

Great, thanks for the quick fix!

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/