Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_github doesn't check SHA1 for remote dependencies when using private repo #1731

Closed
carlganz opened this issue Mar 13, 2018 · 2 comments

Comments

@carlganz
Copy link

Issue: install_github will perform unnecessary reinstallations of dependencies from github when the package is in a private repo

Steps to reproduce:

  1. Create package in private github repo
  2. Make package depend on remote package on github (which is public)
  3. install_github the package in the private repo using your auth token
  4. repeat step 3, and the remote dependency will be reinstalled despite having the same SHA1 as before

Thanks for the extremely useful package.

@jimhester
Copy link
Member

I think this was related to the git2r SSL v1 issue, it should be fixed by upgrading to a newer version of git2r.

@lock
Copy link

lock bot commented Oct 31, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants