Use get directly instead of match.fun #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -152,7 +152,9 @@ dev_remote_type <- function(remotes = "") { | |||
| } else { | |||
| stop("Malformed remote specification '", x, "'", call. = FALSE) | |||
| } | |||
| tryCatch(fun <- match.fun(paste0("install_", tolower(type))), | |||
| tryCatch(fun <- get(x = paste0("install_", tolower(type)), | |||
There was a problem hiding this comment.
I'm not terribly consistent about enforcing this, but I'd prefer subsequent arguments to be indented just one extra level
There was a problem hiding this comment.
Should be fixed by 4903b51
|
Is it desirable to have it search in non-devtools environments? (That's what happens because of the default |
|
I think you mean that commit uses |
|
I edited the comment, no one will ever know! |
|
jimhester@d21c892 should be ready to merge whenever. This will allow use of the |
hadley
added a commit
that referenced
this pull request
Oct 6, 2015
Use get directly instead of match.fun
|
Thanks! |
dckc
added a commit
to PCORnet/DECOY
that referenced
this pull request
Nov 24, 2015
invoke r-lib/devtools#936 magic
jimhester
added a commit
to jimhester/rocker-jenkins
that referenced
this pull request
Dec 30, 2015
This installs all packages from one R session rather than using multiple. It should be slightly faster. I also explicitly attached devtools to avoid r-lib/devtools#936, the fix is not yet on CRAN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used
match.fun(), which has the undesirable effect that the function cannot be found if the devtools namespace is not attached.So
devtools::install_deps()would fail, which is what was happening on travis (https://travis-ci.org/hadley/devtools/builds/81765159#L2108-L2110) when I tried to useRemotes:This fix uses
get()directly in thedevtoolsnamespace, so works regardless if devtools is attached.