Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
46 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,4 @@ | |
^README\.Rmd$ | ||
^cran-comments\.md$ | ||
^CRAN-RELEASE$ | ||
^cran-correspondence$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
Thanks, you have examples for unexported functions which cannot run in | ||
this way. | ||
Please either add gargle::: to the function calls in the examples, omit | ||
these examples or export these functions. | ||
|
||
Please fix and resubmit. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
Thanks, | ||
|
||
Please omit the redundant "from R" in the title. | ||
|
||
Please add a link to the google apis to the description field of your | ||
DESCRIPTION file in the form | ||
<http:...> or <https:...> | ||
with angle brackets for auto-linking and no space after 'http:' and | ||
'https:' | ||
|
||
You write information messages to the console that cannot be easily | ||
suppressed. It is more R like to generate objects that can be used to | ||
extract the information a user is interested in, and then print() that | ||
object. Instead of print()/cat() rather use message()/warning() if you | ||
really have to write text to the console. (f.i.: token_fetch() ) | ||
|
||
Please provide small executable examples in all your exported functions' | ||
Rd files to illustrate the use of the exported function but also enable | ||
automatic testing. | ||
|
||
Please fix and resubmit. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
## CRAN submission notes | ||
|
||
2019-05-09 Initial submission v0.1.0 | ||
|
||
* Clean pass from auto-check service | ||
|
||
2019-05-10 Feedback from CRAN assistant SH re: examples for unexported functions (see email). | ||
|
||
* Ensured that no `.Rd` file would be created for this internal function <https://github.com/r-lib/gargle/commit/c6f9894bcc157f42c4a0f17bf2cad96980134e83>. | ||
|
||
2019-05-09 Resubmit, bump version to v0.1.1 | ||
|
||
* Clean pass from auto-check service | ||
|
||
2019-05-13 Feedback from CRAN assistant MS re: title, description, using `cat()`, examples (see email). | ||
|
||
|
||
|