Skip to content

Commit

Permalink
Keep a record of CRAN process
Browse files Browse the repository at this point in the history
  • Loading branch information
jennybc committed May 21, 2019
1 parent 84707fe commit f39291b
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 0 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Expand Up @@ -16,3 +16,4 @@
^README\.Rmd$
^cran-comments\.md$
^CRAN-RELEASE$
^cran-correspondence$
6 changes: 6 additions & 0 deletions cran-correspondence/2019-05-10_s-h.txt
@@ -0,0 +1,6 @@
Thanks, you have examples for unexported functions which cannot run in
this way.
Please either add gargle::: to the function calls in the examples, omit
these examples or export these functions.

Please fix and resubmit.
21 changes: 21 additions & 0 deletions cran-correspondence/2019-05-13_m-s.txt
@@ -0,0 +1,21 @@
Thanks,

Please omit the redundant "from R" in the title.

Please add a link to the google apis to the description field of your
DESCRIPTION file in the form
<http:...> or <https:...>
with angle brackets for auto-linking and no space after 'http:' and
'https:'

You write information messages to the console that cannot be easily
suppressed. It is more R like to generate objects that can be used to
extract the information a user is interested in, and then print() that
object. Instead of print()/cat() rather use message()/warning() if you
really have to write text to the console. (f.i.: token_fetch() )

Please provide small executable examples in all your exported functions'
Rd files to illustrate the use of the exported function but also enable
automatic testing.

Please fix and resubmit.
18 changes: 18 additions & 0 deletions cran-correspondence/README.md
@@ -0,0 +1,18 @@
## CRAN submission notes

2019-05-09 Initial submission v0.1.0

* Clean pass from auto-check service

2019-05-10 Feedback from CRAN assistant SH re: examples for unexported functions (see email).

* Ensured that no `.Rd` file would be created for this internal function <https://github.com/r-lib/gargle/commit/c6f9894bcc157f42c4a0f17bf2cad96980134e83>.

2019-05-09 Resubmit, bump version to v0.1.1

* Clean pass from auto-check service

2019-05-13 Feedback from CRAN assistant MS re: title, description, using `cat()`, examples (see email).



0 comments on commit f39291b

Please sign in to comment.