Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with current errors.R from processx #151

Merged
merged 2 commits into from Apr 1, 2021
Merged

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Apr 1, 2021

I did this because it feels like call. does not have the usual effect. I figured this has since been fixed in the compat file. But even after I update, call. doesn't work the way I expect.

Is this expected behaviour? I'm talking about the Error in FALSE part.

gh:::gh_pat("aa")
#> Error in FALSE: GitHub PAT must have one of these forms:
#>   * 40 hexadecimal digits (older PATs)
#>   * A 'ghp_' prefix followed by 36 to 251 more characters (newer PATs)

Created on 2021-04-01 by the reprex package (v1.0.0.9002)

Generated by

gh/R/gh_token.R

Lines 84 to 89 in 86eb3d9

throw(new_error(
"GitHub PAT must have one of these forms:",
"\n * 40 hexadecimal digits (older PATs)",
"\n * A 'ghp_' prefix followed by 36 to 251 more characters (newer PATs)",
call. = FALSE
))

@jennybc jennybc requested a review from gaborcsardi April 1, 2021 18:29
@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi merged commit d15e085 into master Apr 1, 2021
@gaborcsardi gaborcsardi deleted the update-errors branch April 1, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants