Skip to content

Fixed NAMESPACE - #3

Closed
lcolladotor wants to merge 3 commits into
r-lib:masterfrom
lcolladotor:master
Closed

lcolladotor wants to merge 3 commits into
r-lib:masterfrom
lcolladotor:master

Conversation

@lcolladotor

Copy link
Copy Markdown

Fixed #2 by re-making the NAMESPACE and all the docs with devtools::document().

…cumentation and fix the NAMESPACE. Then used check_doc('gmailr'); system.time(check('gmailr')) to check the package. Only found 1 NOTE related to the Make and TODO.md files, which is nothing to worry about.
@lcolladotor

Copy link
Copy Markdown
Author

The issue #2 is fixed in this version as shown below:

> library(gmailr)
> gmail_auth("new-installed-applications.json")
> x <- messages("test", 5)
> x
        message_id        thread_id
## Truncated output

Session info

> sessionInfo()
R version 3.1.1 (2014-07-10)
Platform: x86_64-apple-darwin10.8.0 (64-bit)

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] gmailr_0.0.2   colorout_1.0-2

loaded via a namespace (and not attached):
[1] base64enc_0.1-2 digest_0.6.4    httr_0.4        jsonlite_0.9.10
[5] RCurl_1.95-4.3  stringr_0.6.2

@jimhester

Copy link
Copy Markdown
Member

Hey Leo,

First thank you for playing with the package and submitting bug reports, they are very helpful! Could you split these into separate pull requests (different branches), so I don't have to merge them all at once?

Thanks!

@lcolladotor

Copy link
Copy Markdown
Author

I see that you already merged/re-did some of the things I suggested.

I was learning a bit more about git (see http://stackoverflow.com/questions/12660839/pull-request-for-only-certain-files-commits) on how to separate the commits into different branches. Got 2 of them, but couldn't get the 3rd (most recent) one. But well, it seems that you got everything already except for this small change.

Anyhow, I'll keep in mind next time that you want separate pull requests for each commit.

@lcolladotor lcolladotor closed this Sep 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NAMESPACE is not updated

2 participants