Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider cache pruning #207

Closed
hadley opened this issue Feb 9, 2023 · 1 comment · Fixed by #288
Closed

Consider cache pruning #207

hadley opened this issue Feb 9, 2023 · 1 comment · Fixed by #288
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Feb 9, 2023

Maybe using cachem?

@hadley hadley added the feature a feature request or enhancement label May 9, 2023
@hadley
Copy link
Member Author

hadley commented Aug 17, 2023

Or just using the same implementation as cachem: https://github.com/r-lib/cachem/blob/main/R/cache-disk.R#L396-L467

Would require adding max_age, max_n and max_size parameters to req_cache(). Probably reasonable to default max_size to 1 Gb.

Probably not worth automatically clearing based on expires etc because that would require reading each file. But should check that we are deleting these files from the cache when we encounter them.

hadley added a commit that referenced this issue Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant