Change to priority queue of pointers to Callback objects #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #39. It uses
shared_ptrs to ensure that the objects get cleaned up without much fuss.I've tested it on my Mac, and with
RDassertthreadandRDsanfrom the r-debug Docker image, and I no longer see any errors. Previously, it would usually give weird errors and crash on Mac, and withRDassertthread, it would error out every time with a failed thread assertion.I added a NEWS item to 0.7 -- if it's too late for 0.7, I can move it to a new section.