Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer require string what/with #84

Merged
merged 3 commits into from Jan 12, 2021
Merged

No longer require string what/with #84

merged 3 commits into from Jan 12, 2021

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 11, 2021

Turned out to be very simple after all the refactoring 馃槃

@hadley hadley requested a review from lionel- January 11, 2021 20:17
lionel-
lionel- approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

R/deprecated.R Show resolved Hide resolved
R/spec.R Outdated Show resolved Hide resolved
R/spec.R Show resolved Hide resolved
tests/testthat/test-deprecated.R Outdated Show resolved Hide resolved
hadley and others added 2 commits January 12, 2021 07:10
@hadley @lionel-
Apply suggestions from code review
1c71a65 
Co-authored-by: Lionel Henry <lionel.hry@gmail.com>
@hadley
Update snapshot
23a5da2
@hadley hadley merged commit 2dfdd6e into master Jan 12, 2021
@hadley hadley deleted the no-quote branch January 12, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel- lionel- lionel- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hadley @lionel-