Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor commas_linter to XPath #1214

Merged
merged 1 commit into from
May 24, 2022
Merged

refactor commas_linter to XPath #1214

merged 1 commit into from
May 24, 2022

Conversation

AshesITR
Copy link
Collaborator

Part of #1186

@AshesITR
Copy link
Collaborator Author

Crazy how much code can be saved by XPath 😮

@MichaelChirico
Copy link
Collaborator

glorious xpath 🙌🙌🙌

MichaelChirico
MichaelChirico approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any need to mess with the source markers here?

@AshesITR
Copy link
Collaborator Author

Yes, could be done as a follow-up, similar to spaces_inside_linter.
Currently, all lints mark the comma, which is fine for spaces before, but useless for spaces after.

@AshesITR AshesITR merged commit 0965a7b into main May 24, 2022
@AshesITR AshesITR deleted the cyclocomp/commas_linter branch May 24, 2022 20:51
@MichaelChirico MichaelChirico mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshesITR @MichaelChirico