Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved & generalized semicolon linter [patch] #181

Closed
fangly opened this issue Oct 24, 2016 · 3 comments
Closed

Improved & generalized semicolon linter [patch] #181

fangly opened this issue Oct 24, 2016 · 3 comments

Comments

@fangly
Copy link
Contributor

fangly commented Oct 24, 2016

Hi,

I noticed that trailing_semicolons_linter() missed some cases (when the statements are not enclosed in "function(){}"). Further, I wanted to be able to report compound semicolons, semicolons between two statements on the same line.

So, this is what I did:
* added more tests to trailing_semicolons_linter()
* had to improve trailing_semicolons_linter()'s code to pass all tests
* generalized trailing_semicolons_linter() so that it also detects compound semicolons
* added the option to report compound semicolons, trailing, or both
* renamed it to semicolon_linter() to match the new functionality

The result is in this patch: 0001-Improved-generalized-trailing_semicolons_linter-now-.zip

Best,

Florent

@jimhester
Copy link
Member

If you name the files .patch and don't zip them, I think GitHub will automatically render them in-line.

@fangly
Copy link
Contributor Author

fangly commented Oct 25, 2016

Unfortunately, GitHub does not support ".patch" file type.
I have tried ".txt", which is allowed but the content is not shown in-line.
Florent

@fangly fangly changed the title Improved & generalized semicolon linter Improved & generalized semicolon linter [patch] Oct 26, 2016
@fangly
Copy link
Contributor Author

fangly commented Mar 13, 2017

Fixed in #214

@fangly fangly closed this as completed Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants