refactor xml_nodes_to_lints() lint location to XPath #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #' to the `Lint` object. If `lint_message` is a `function`, | ||
| #' this function is first applied to `xml` (so it should be a | ||
| #' function taking an `xml_node` as input and must produce a | ||
| #' length-1 character as output). If `lint_message` is a character vector the same length as `xml`, |
There was a problem hiding this comment.
do we want to add a test to enforce the equal-lengths part more strictly?
There was a problem hiding this comment.
Nonequal lengths will generate a recycling warning by .mapply(), right?
There was a problem hiding this comment.
right... tidyverse usually hates recycling though and tends to error instead
There was a problem hiding this comment.
Sounds like a good candidate for a sanity-check follow up (in addition to the start <= column <= nchar(line) check discussed below.
|
last few comments here. good overall! I think this API maximizes flexibility & has good defaults. |
…de_linter() even more
|
The build failure looks sporadic. Restarting should fix it. |
MichaelChirico
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1215
xml_nodes_to_lints()to its own fileLint()slist()containingxml_nodes, even if it's not classedxml_nodesetmatch_after_endusages to XPath based locationscommas_linter()commas_linter()xml_nodes_to_lints()spaces_inside_linter()to usexml_nodes_to_lints()