Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dependencies with no exports #1509

Merged
merged 6 commits into from Aug 25, 2022
Merged

Handle dependencies with no exports #1509

merged 6 commits into from Aug 25, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Aug 25, 2022 •
edited

Closes #1503
Closes #1424

@IndrajeetPatil IndrajeetPatil mentioned this pull request Aug 25, 2022
Closed
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review August 25, 2022 14:55
MichaelChirico
MichaelChirico reviewed Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now for the fun part -- could you please add a test?

FWIW it may be possible to use base datasets package

@IndrajeetPatil
Copy link
Collaborator Author

FWIW it may be possible to use base datasets package

Sounds good. Will try to add a test.

@IndrajeetPatil
Copy link
Collaborator Author

@MichaelChirico I confirmed that the test fails on main branch.

@MichaelChirico
Copy link
Collaborator

Thanks!

@MichaelChirico MichaelChirico merged commit 7d8c2c4 into main Aug 25, 2022
@MichaelChirico MichaelChirico deleted the 1503_patch branch August 25, 2022 16:00
@IndrajeetPatil IndrajeetPatil mentioned this pull request Sep 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@IndrajeetPatil @MichaelChirico