-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent definition of options and their defaults #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideas borrowed from renv, CC @kevinushey.
Bundles all options under
?pillar_options
.This proposal uses a tiny bit of metaprogramming. It allows accessing options via
pillar_options$bold()
and setting them viapillar_options$bold(value)
. Local options are supported too. In addition, there are internal accessors of the formget_pillar_option_bold()
,set_pillar_option_bold()
andlocal_pillar_option_bold()
.The infastructure file
aaa-options.R
is package-agnostic, theoptions.R
file contains only a little boilerplate code and the definition of the option getters; to use e.g. in tibble I'd replace pillar with tibble in the file and tweak thetibble_options
object.Tests were created and edited using the multi-cursor feature of RStudio.