Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to suppress hints #575

Closed
krlmlr opened this issue Jul 28, 2022 · 12 comments · Fixed by #577
Closed

Add option to suppress hints #575

krlmlr opened this issue Jul 28, 2022 · 12 comments · Fixed by #577

Comments

@krlmlr
Copy link
Member

krlmlr commented Jul 28, 2022

e.g. ℹ Use `print(n = ...)` to see more rows .

CC @juliasilge.

@krlmlr
Copy link
Member Author

krlmlr commented Jul 28, 2022

Should it be off by default in non-interactive environments?

@mine-cetinkaya-rundel
Copy link

I think so, it would be awkward to have to show the code to turn them off in slides. And doing it with some global options can also get confusing for people seeing what's on slides and seeing their output doesn't exactly match up.

@topepo
Copy link
Member

topepo commented Aug 16, 2022

I would really like to have any changes to tibbles vetted in the tidyverse meeting. This is wreaking havoc with snapshots and adding unicode characters to our Rd files (which requires me to figure out and do a parsnip submission).

The printing matters and we need more oversight on changes. I didn't seen anything about this in news files either.

(edit for spelling)

@hadley
Copy link
Member

hadley commented Aug 16, 2022

Yes, should definitely be turned off interactively, and we should offer an option to globally suppress. @krlmlr could you please try and priortise this?

@topepo
Copy link
Member

topepo commented Aug 17, 2022

An option to turn it off entirely would be good too. The 'ℹ' adds unicode to our Rd files and, for slides, it eats up one more row of output.

@krlmlr
Copy link
Member Author

krlmlr commented Aug 17, 2022

Taking a look now.

@krlmlr
Copy link
Member Author

krlmlr commented Aug 17, 2022

Apologies for the trouble it causes, waiting until after the conf would have been better here.

Updated the NEWS file.

@krlmlr
Copy link
Member Author

krlmlr commented Aug 17, 2022

Does #577 work for you? I can push a fix to CRAN tomorrow.

@krlmlr
Copy link
Member Author

krlmlr commented Aug 18, 2022

In the main branch now, does it work for you? Is the option name "pillar.advice" good?

@hadley
Copy link
Member

hadley commented Aug 18, 2022

Thanks for working on this! Option name sounds good to me.

@krlmlr
Copy link
Member Author

krlmlr commented Aug 19, 2022

pillar 1.8.1 on CRAN now.

@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants