Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scientific formatting #14

Merged
merged 9 commits into from
Jun 30, 2017
Merged

Fix scientific formatting #14

merged 9 commits into from
Jun 30, 2017

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 30, 2017

  • Largely uses the same code as decimal formatting
  • Negative and NA/Inf are displayed properly (but is the alignment correct)?

Build output: https://travis-ci.org/hadley/colformat/builds/248730482#L632.

Fixes #8.

Next steps:

  • Simultaneously compute data for both decimal and scientific notation
  • Get rid of the ugly format(format()) pattern

@krlmlr krlmlr requested a review from hadley June 30, 2017 10:44
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change the default NA etc styling so it's more readable on travis (and in general in consoles with black background and fewer colours)

This was referenced Jun 30, 2017
@krlmlr krlmlr merged commit 0a35999 into r-lib:master Jun 30, 2017
@krlmlr krlmlr deleted the f-#8-sci-neg branch June 30, 2017 14:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative numbers in scientific notation miss the minus sign
2 participants