Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken characters with pkgdown 1.5.0 #1284

Closed
Bisaloo opened this issue Apr 2, 2020 · 3 comments
Closed

Broken characters with pkgdown 1.5.0 #1284

Bisaloo opened this issue Apr 2, 2020 · 3 comments

Comments

@Bisaloo
Copy link
Contributor

Bisaloo commented Apr 2, 2020

I just noticed strange characters in the pkgdown website for one of the packages I'm maintaining https://docs.ropensci.org/lightr/

In the NEWS page, you can see things like (this was a regression compared to pavo�s or test files provided by M.D. S.

These characters are absent from the source file so it's due to something during the conversion to HTML:

https://raw.githubusercontent.com/ropensci/lightr/master/NEWS.md

It's of course also obvious on the landing page / README, where the emojis in the titles are mangled up, but I don't want you to think that this issue is related to emojis only.

Please note that this issue is not related to rOpenSci since I can reproduce locally with devtools::build_site() (with pkgdown 1.5.0).

Note that I didn't have this issue until very recently (pkgdown 1.4.9000, didn't record the exact commit hash).

I will try to work on a reprex as soon as possible

@maelle
Copy link
Collaborator

maelle commented Apr 3, 2020

Related: #1287?

I see the problem in another website but have not time to make a reprex myself yet, sorry.

@Bisaloo
Copy link
Contributor Author

Bisaloo commented Apr 3, 2020

Interestingly, I couldn't see this issue the first time my website was deployed with pkgdown 1.5.0. Now, I'm starting to wonder if this could be caused by r-lib/xml2#293.

@hadley
Copy link
Member

hadley commented Apr 3, 2020

Closing as duplicate; will continue discussion at #1287

@hadley hadley closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants