Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R6 links to superclass methods #1476

Closed
gaborcsardi opened this issue Feb 1, 2021 · 2 comments · Fixed by #1806
Closed

Fix R6 links to superclass methods #1476

gaborcsardi opened this issue Feb 1, 2021 · 2 comments · Fixed by #1806
Labels
feature a feature request or enhancement linking 📎

Comments

@gaborcsardi
Copy link
Member

If the superclass is in the a different package. E.g. callr::r_session -> processx::process. (And check that they work if the superclass is in the same package.)

This might need some help from roxygen2.

@hadley
Copy link
Member

hadley commented Oct 6, 2021

This already looks ok? https://callr.r-lib.org/reference/r_session.html

Oooooh it's specifically the superclass methods

@hadley
Copy link
Member

hadley commented Oct 6, 2021

Example html:

<span class="pkg-link" data-pkg="processx" data-topic="process" data-id="as_ps_handle"><a href="../../processx/html/process.html#method-as_ps_handle"><code>processx::process$as_ps_handle()</code></a></span>

Can use downlit::href_topic() to find the url and then add the fragment from data-id

@hadley hadley added the feature a feature request or enhancement label Oct 6, 2021
hadley added a commit that referenced this issue Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement linking 📎
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants