Add BS4 templates and assets (with help from @jayhesselberth). #1536

maelle · 2021-02-25T14:58:31Z

Fix #1409

headroom config inspired by quillt.
syntax highlighting colours come from distill. the opting-out will be documented in [draft!]starting customization docs #1490
darker links than Bootstrap default, to ensure sufficient contrast

Not tackled here:

accessible anchor links #1553
empty GitHub link in navbar (this is another accessibility error according to https://wave.webaim.org)
maybe the presence of the TOC should depend on the headers present cf https://6046425e1cd1eb0831ea6824--pkgdown-dev.netlify.app/code_of_conduct

more changes oops

DESCRIPTION

R/build-home-index.R

R/navbar.R

R/render.r

maelle · 2021-02-26T08:11:41Z

R/render.r

+  )
+
+  # Function needed for indicating where that deps folder is compared to here
+  transform_path <- function(x) {


this and the navbar link creation might need to share logic? not sure. in any case both involve depth.

Can we use an fs function for this?

I've now read fs docs again, and I don't see any good fit.

fs::path_rel() doesn't help?

R/render.r

inst/assets/BS3/pkgdown.js

inst/templates/BS4/footer.html

maelle · 2021-03-11T16:05:38Z

R/render.r

+  data$headdeps <- data_deps(pkg = pkg, depth = depth)
+
+  # Potential opt-out of syntax highlighting CSS
+  data$needs_highlight_css <- !isFALSE(pkg$meta[["template"]]$params$highlightcss)


we could pass the code background color via a bootstrap variable but it'd make it harder to opt-out of all the syntax highlighting styling at once.

maelle · 2021-03-11T16:17:54Z

Note to self: NOTE about not portable file paths in tests.

hadley

I've noted a few minor code style improvements; I think you should merge soon (no need to ping me for another review) and then we can start tracking smaller problems in individual issues.

NEWS.md

R/build-news.R

R/html-tweak.R

R/navbar.R

hadley · 2021-03-12T14:51:17Z

R/render.r

+  )
+
+  # Function needed for indicating where that deps folder is compared to here
+  transform_path <- function(x) {


fs::path_rel() doesn't help?

Co-authored-by: Hadley Wickham <h.wickham@gmail.com>

maelle added 3 commits February 25, 2021 15:56

start

ca23faf

more changes oops

oops

e3eeead

fix tests

d7d0268

maelle commented Feb 26, 2021

View reviewed changes

DESCRIPTION Show resolved Hide resolved

maelle commented Feb 26, 2021

View reviewed changes

R/build-home-index.R Outdated Show resolved Hide resolved

can't change current sites or it will break CSS rules

ece77a8

maelle commented Feb 26, 2021

View reviewed changes

R/navbar.R Show resolved Hide resolved

maelle commented Feb 26, 2021

View reviewed changes

R/render.r Show resolved Hide resolved

maelle commented Feb 26, 2021

View reviewed changes

R/render.r Show resolved Hide resolved

maelle commented Feb 26, 2021

View reviewed changes

inst/assets/BS3/pkgdown.js Show resolved Hide resolved

maelle added 2 commits February 26, 2021 09:15

fixes

5fe762e

update toc

129f562

maelle mentioned this pull request Feb 26, 2021

rmarkdown breaks heading anchors for Pandoc > 2.8 #1538

Closed

maelle added 8 commits February 26, 2021 13:53

repair

4be62af

fix class size

c036c52

call get_bs_version only once

3b69236

oops

4895fdf

try passing logo

fe6ca22

logo + back to vanilla 😢

ca122b9

bye bye logo hack

46a41c6

a bit too big

e225f98

This comment has been minimized.

Sign in to view

Merge branch 'master' into null-or

48e9194

This comment has been minimized.

Sign in to view

maelle commented Feb 26, 2021

View reviewed changes

inst/templates/BS4/footer.html Show resolved Hide resolved

smaller logo

f3d5984

maelle commented Mar 11, 2021

View reviewed changes

maelle added 5 commits March 11, 2021 17:06

namespace

9d28738

fix note

6f34532

oops

f6cc38d

typo

0c255ef

h top

82ca3dd

h

23c6214

maelle requested a review from hadley March 11, 2021 16:27

maelle added 3 commits March 11, 2021 17:36

less dramatic

24d2c72

update news

6aee7f2

actual drop down fix

8df0bc1

maelle mentioned this pull request Mar 12, 2021

footnotes #1567

Closed

hadley approved these changes Mar 12, 2021

View reviewed changes

maelle and others added 13 commits March 12, 2021 16:16

Update NEWS.md

d4c2346

Co-authored-by: Hadley Wickham <h.wickham@gmail.com>

Update NEWS.md

eaec19e

Co-authored-by: Hadley Wickham <h.wickham@gmail.com>

toc

5100517

place-holder link

0ee04a1

feedback + indent

c18764c

oops

08c18a2

clean CSS

325d8b8

this is not supposed to have changed

aeba340

refix indent

a27321c

fix

34c2cfc

should not change

f150435

shouldn't change

6690d0a

no

39a0914

maelle changed the title ~~BS4 work~~ Add BS4 templates and assets (with help from @jayhesselberth). Mar 15, 2021

maelle merged commit bebcebb into master Mar 15, 2021

maelle deleted the null-or branch March 15, 2021 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add BS4 templates and assets (with help from @jayhesselberth). #1536

Add BS4 templates and assets (with help from @jayhesselberth). #1536

maelle commented Feb 25, 2021 •

edited

maelle Feb 26, 2021

hadley Mar 8, 2021

maelle Mar 11, 2021

hadley Mar 12, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

maelle Mar 11, 2021

maelle commented Mar 11, 2021

hadley left a comment

hadley Mar 12, 2021

Add BS4 templates and assets (with help from @jayhesselberth). #1536

Add BS4 templates and assets (with help from @jayhesselberth). #1536

Conversation

maelle commented Feb 25, 2021 • edited

maelle Feb 26, 2021

Choose a reason for hiding this comment

hadley Mar 8, 2021

Choose a reason for hiding this comment

maelle Mar 11, 2021

Choose a reason for hiding this comment

hadley Mar 12, 2021

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

maelle Mar 11, 2021

Choose a reason for hiding this comment

maelle commented Mar 11, 2021

hadley left a comment

Choose a reason for hiding this comment

hadley Mar 12, 2021

Choose a reason for hiding this comment

maelle commented Feb 25, 2021 •

edited