Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Think about syntax highlighting with dark backgrounds #1823

Closed
hadley opened this issue Oct 16, 2021 · 2 comments · Fixed by #1841
Closed

Think about syntax highlighting with dark backgrounds #1823

hadley opened this issue Oct 16, 2021 · 2 comments · Fixed by #1841
Labels
feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues

Comments

@hadley
Copy link
Member

hadley commented Oct 16, 2021

I removed highlightcss support since it didn't get ported in the move to scss generation.
@hadley hadley added feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues labels Oct 18, 2021
@hadley
Copy link
Member Author

hadley commented Oct 18, 2021

https://github.com/quarto-dev/quarto-cli/blob/main/src/resources/pandoc/highlight-styles/arrow-dark.theme

@hadley
Copy link
Member Author

hadley commented Oct 18, 2021

Maybe just convert all themes in https://github.com/quarto-dev/quarto-cli/tree/main/src/resources/pandoc/highlight-styles to scss, and then make available in pkgdown.

@hadley hadley mentioned this issue Oct 19, 2021
Merged
hadley added a commit that referenced this issue Oct 20, 2021
@hadley
Syntax highlighting choices (#1841)
19648f1 
Generate SCSS stylesheets from quarto's pandoc themes and then allow the user to choose with a new `template.theme` parameter.

Fixes #1823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement front end 🌷 General HTML, CSS, and JS issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Syntax highlighting choices r-lib/pkgdown
1 participant
@hadley