Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes with code block fail with bootstrap v5 #2042

Closed
banfai opened this issue Feb 16, 2022 · 0 comments 路 Fixed by #2043
Closed

Footnotes with code block fail with bootstrap v5 #2042

banfai opened this issue Feb 16, 2022 · 0 comments 路 Fixed by #2043
Labels
bug an unexpected problem or unintended behavior front end 馃尫 General HTML, CSS, and JS issues
Milestone

Comments

@banfai
Copy link
Contributor

banfai commented Feb 16, 2022

vignettes/test/rendering.Rmd L16-L18
If we change those to

Nay[^footnote]

[^footnote]: Including **footnotes** with embedded code:
```r
1 + 2
```
馃槩 

then it stops working with

Error in vapply(footnotes, FUN.VALUE = character(1), function(x) { : 
  values must be length 1,
 but FUN(X[[1]]) result is length 3

as.character(xml2::xml_children(x), options = character())

returns a length-3 vector instead of length-1

@maelle maelle added the bug an unexpected problem or unintended behavior label Apr 25, 2022
@hadley hadley added the front end 馃尫 General HTML, CSS, and JS issues label May 31, 2022
@hadley hadley added this to the v2.0.4 milestone May 31, 2022
hadley added a commit that referenced this issue Jun 1, 2022
Fixes #2042

Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior front end 馃尫 General HTML, CSS, and JS issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants