Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site no longer compiling with 2.0.4 and has_concept #2126

Closed
tylerlittlefield opened this issue Jun 13, 2022 · 5 comments · Fixed by #2136
Closed

Site no longer compiling with 2.0.4 and has_concept #2126

tylerlittlefield opened this issue Jun 13, 2022 · 5 comments · Fixed by #2136

Comments

@tylerlittlefield
Copy link

I noticed that my github action started failing when I introduced has_concept in my _pkgdown.yml file to organize my reference page. I installed pkgdown 2.0.3 and the error went away. My pkgdown config and CI logs below:

I also noticed that 2.0.4 introduced some additional checks on this file. Has me wondering, am I not using has_concepts correctly?

@tylerlittlefield tylerlittlefield changed the title Site no longer compiling with 2.0.4 and has_concepts Site no longer compiling with 2.0.4 and has_concept Jun 13, 2022
@dmurdoch
Copy link
Contributor

dmurdoch commented Jun 13, 2022

I think you've got it right, but there's an issue here:

topics <- pkg$topics[, c("name", "file_out", "title", "funs", "alias", "internal")]

The list of columns should include "concepts"; if you add it, the problem is fixed.

Elsewhere code refers to topics$file_in, topics$keywords, and topics$icon, but I don't know if those references are affected by line 186.

@tylerlittlefield
Copy link
Author

Good catch! For the time being, I am just going to install 2.0.3 until this is resolved: https://github.com/tyluRp/strava/blob/main/.github/workflows/pkgdown.yaml#L36-L38

@hadley
Copy link
Member

hadley commented Jun 13, 2022

Thanks for reporting — I'll try and get another release out ASAP.

@AARON-CLARK
Copy link

AARON-CLARK commented Jun 15, 2022

Similar to has_concept(), I can confirm that has_keyword() is also borked in pkgdown 2.0.4.

@mpadge
Copy link

mpadge commented Jun 22, 2022

Until 2.0.4 appears on CRAN, temp workaround for doc build fails on GitHub is to change pkgdown.yaml to use dev instead of CRAN version:

      - uses: r-lib/actions/setup-r-dependencies@v2
        with:
          #extra-packages: any::pkgdown, local::.
          extra-packages: github::r-lib/pkgdown, local::.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants