Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as_html.tag_cr is defined twice with different definitions #2400

Closed
dmurdoch opened this issue Feb 18, 2024 · 1 comment · Fixed by #2413
Closed

as_html.tag_cr is defined twice with different definitions #2400

dmurdoch opened this issue Feb 18, 2024 · 1 comment · Fixed by #2413
Milestone
2.0.8

Comments

@dmurdoch
Copy link
Contributor

The first defn is here:

pkgdown/R/rd-html.R

Line 488 in 3979e7c

as_html.tag_cr <- function(x, ...) "<br >"

The second one is here:

pkgdown/R/rd-html.R

Line 505 in 3979e7c

as_html.tag_cr <- function(x, ...) "<br />"

The first definition will be replaced by the second, so if the second one is the intended one, things are fine, just a little confusing.
@hadley hadley added this to the 2.0.8 milestone Mar 11, 2024
@hadley
Copy link
Member

hadley commented Mar 11, 2024

Ooops

hadley added a commit that referenced this issue Mar 12, 2024
@hadley
Remove duplicate \cr definition
320a155 
And use HTML5. Fixes #2400.

Merge commit '6fc98fa6773df431471b2b28ba59361d647fafc2'
@hadley hadley mentioned this issue Mar 12, 2024
Merged
hadley added a commit that referenced this issue Mar 12, 2024
@hadley
Remove duplicate \cr definition (#2413)
ef01e76 
And use HTML5. Fixes #2400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.8
Development

Successfully merging a pull request may close this issue.

Remove duplicate \cr definition r-lib/pkgdown
2 participants
@hadley @dmurdoch