Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase flexibility of news title matching #1036

Merged
merged 3 commits into from Jun 23, 2019
Merged

Conversation

hadley
Copy link
Member

@hadley hadley commented May 20, 2019

Included a decent amount of refactoring, first to make the regular expression more readable, and then to make news_version return something that was easier to test.

Fixes #980

Included a decent amount of refactoring, first to make the regular expression more readable, and then to make news_version return something that was easier to test.

Fixes #980
@jennybc
Copy link
Member

jennybc commented Jun 22, 2019

This would be great to merge, so we can see NEWS info re: development version.

@jayhesselberth
Copy link
Collaborator

jayhesselberth commented Jun 22, 2019

Looks like there's a test failure specifically on R 3.2:

── 1. Error: github links are added to news items (@test-build-news.R#8)  ──────
unused argument (perl = TRUE)
1: data_news(pkg) at testthat/test-build-news.R:8
2: news_version(titles)
3: regexec(pattern, x, perl = TRUE)

Alternatively we could use rematch2::re_match() here.

@jayhesselberth jayhesselberth merged commit 9619b43 into master Jun 23, 2019
@jayhesselberth jayhesselberth deleted the news-versions branch June 23, 2019 12:06
@jennybc
Copy link
Member

jennybc commented Jun 23, 2019

Works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

News sections not rendered if version is in parentheses
3 participants