Escape html in comments in author info from DESCRIPTION #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it should even use Example comment <- "Kramer reviewed the package for ropensci,
see <https://github.com/ropensci/software-review/issues/256>"
pkgdown:::linkify(comment)
#> [1] "Kramer reviewed the package for ropensci,\n see <<a href='https://github.com/ropensci/software-review/issues/256'>https://github.com/ropensci/software-review/issues/256</a>>"Created on 2020-01-16 by the reprex package (v0.3.0) |
|
Thanks, looks good! |
hadley
reviewed
Mar 10, 2020
| @@ -26,3 +26,14 @@ test_that("names can be removed from persons", { | |||
| expect_length(remove_name(p4$comment, "ORCID"), 0) | |||
| expect_length(remove_name(p5$comment, "ORCID"), 0) | |||
| }) | |||
|
|
|||
| test_that("Comments in authors info are linkified", { | |||
| p <- list(name = "Jane Doe", | |||
There was a problem hiding this comment.
Can you please use standard tidyverse styling?
There was a problem hiding this comment.
Oops, now I think it looks like https://style.tidyverse.org/syntax.html#long-lines :-)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jeroen
fix #1205