-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix “\special” in usage documentation #1345
Conversation
Can you please point to the docs for |
I don’t think it’s mentioned in R-exts. It’s mentioned in Duncan Murdoch’s 2010 description of |
In that case, can you add a comment above |
See https://developer.r-project.org/parseRd.pdf Table 3. Example usage: src/library/utils/man/Question.Rd.
15d50e5
to
bf688bf
Compare
Gladly. How’s the new commit? Are the path references OK or should I include actual links into the Git mirror? I’ve also force-pushed a rebase against master, since the previous PR had a conflict. I’ve just noticed that the ‘rlang’ package currently has no “usage” section for its bang bang, big bang and interpolation operators in |
Could you make them real links please? Agreed about use in rlang - there are probably a few places we can use it now that we know it exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you you please add a news bullet (it should briefly describe the change and end with (@yourname, #issuenumber)
), and then I'll merge.
See https://developer.r-project.org/parseRd.pdf Table 3. Example usage: src/library/utils/man/Question.Rd.
The reference usage parser was missing support for the Rd
\special
tag. This PR adds the missing support.The
\special
tag is rarely used so it’s easily overlooked. The PR contains an addition to the test project undertests/testthat/assets/reference
which illustrates the usage for the?
operator (mirroring that of the core R?
operator defined in ‘utils’).It’s worth considering how such “special” operators should be rendered in the pkgdown reference index (currently,
?
is rendered as`?()`
, which is … idiosyncratic). But this affects operators regardless of their Rd usage declaration, and is therefore beyond the scope of this PR.