-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow template packages to provide a default configuration _pkgdown.yml
#1565
Conversation
R/init.R
Outdated
"assets" | ||
) | ||
|
||
if (length(assets) > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current code was assuming a template package had to provide assets, which this PR fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check should go in copy_asset_dir()
R/init.R
Outdated
"assets" | ||
) | ||
|
||
if (length(assets) > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check should go in copy_asset_dir()
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
_pkgdown.yml
Fix #1499